Extension hooks and skeleton of phongo #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| PHP_FUNCTION(bson_encode); | ||
| PHP_FUNCTION(bson_decode); | ||
| PHP_FUNCTION(bson_to_json); |
There was a problem hiding this comment.
Should there be a json_to_bson() function, too? Or rather, bson_encode_json and bson_decode_json.
There was a problem hiding this comment.
Not really. Don't think libmongoc supports that - and you can do it in userland anyway: bson_encode(json_decode($json));.
I'm unsure what the usecase for this is would be.
bson_to_json() is handy to debug stuffz...
There was a problem hiding this comment.
This would be for supported extended JSON. I believe Christian actually has methods for this, too.
There was a problem hiding this comment.
ah. from Extended JSON... I guess that makes sense.
Could also help mocking up bson I suppose
|
|
||
| static zend_function_entry php_phongo_cursor_me[] = { | ||
| /** | ||
| * Returns the CursorId |
bjori
added a commit
that referenced
this pull request
Jun 19, 2014
Extension hooks and skeleton of phongo
bjori
changed the title
jmikola
referenced
this pull request
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.